0.15.5 RC1 incomplete quick and dirty check list

Lafiel

Since 0.15.5 & 0.15.6 are QoL, fixes, and optimization versions I'll use this opportunity to list some of the bugs that's still around as a sort of check list. From the top of my head I may not remember them all, though. This may not include recent bugs I've submitted.

crash with double swapping on part destruction: a part swaps to its alternate part; at some point it swaps back; the crash happens when the alternative part is destroyed. I'm guessing its due to the nature of some internal components data not properly handled in the swapping.
blueprint/swapping crash as discussed before
UIToggles with popup choices: this seems to have several effects. A part with a preset different from default 0 doesn't take effect e.g. visually seen with optional blueprints. For the same reason this might be the cause for ToggledComponent crashes since related toggles are not properly turned off/on leading to collisions.
visual animation bug (with rotation); possibly due to temporal switching/timed rotation
storage consumer/storage and crew pathing crash as discussed before
Bullet inheritance and added (area/explosion)ammodrain has no effect. Might be related to some TriggeredEffects cases failing, too.

I'll forgo buff and other converter bugs....

Roasted

how about those crew quarters of yours that you where able to select the amount of crew that you wanted. that also caused a crash

Lafiel

That's part of the blueprint and swapping crash. Walt would have to redesign the whole process them to fix it.

Lafiel

A multi bug test mod (all parts in WeaponsProjectile group):
https://cdn.discordapp.com/attachments/614304659229900814/647910944084852737/test_mod19.zip

UIBUtton (popout) if the ButtonToggle with default setting itself is used. A sprite will show inside the part the mode that is active.
free buff is used; instead of positive add-up it starts with subtraction from 100% then only after reaching 0% it starts to add. Use the bugged_part01 to buff each other.
proper buff but bufftoggle with MinBuffValue and MaxBuffValue don't seem to work. Use engine_buff_part to buff bugged_part01. A sprite will show inside the part if a bufftoggle check is successful up to 600% buff.

https://cdn.discordapp.com/attachments/614304659229900814/647916520734982226/bugged_test_ship.ship.png

Walt

Lafiel free buff is used; instead of positive add-up it starts with subtraction from 100% then only after reaching 0% it starts to add. Use the bugged_part01 to buff each other.

This is because you have IconTextAdd = -100 in the buff. Note that the value displayed for the buff is +-75% (note the minus sign). If there's a bug here, it is only that it's displaying a + in front of a negative number. Otherwise it seems to be working perfectly.

EDIT: Actually, the + is data-driven. You can remove it from the buff by using a different string key.

Walt

Lafiel proper buff but bufftoggle with MinBuffValue and MaxBuffValue don't seem to work. Use engine_buff_part to buff bugged_part01. A sprite will show inside the part if a bufftoggle check is successful up to 600% buff.

This isn't working because the part doesn't have RailgunShot in its ReceivableBuffs. Adding it makes it work fine.

Walt

Lafiel UIBUtton (popout) if the ButtonToggle with default setting itself is used. A sprite will show inside the part the mode that is active.

This doesn't work because the default behavior of UIToggle is to be OFF whenever choice 0 is selected and ON when any other choice is selected. To make it work the way you want, set ToggledOnChoices = [0].

Lafiel

Another annoying short coming rather than a real bug is when buff providers are inside ToggledComponents the buff amount won't show even if the buff has explicit code for displaying stats. Otherwise they seem to work.

(reminder for later: multi-storage converter bug with multi-proxies especially when used to supply only the first will toggle for everything)

Walt

Lafiel Another annoying short coming rather than a real bug is when buff providers are inside ToggledComponents the buff amount won't show even if the buff has explicit code for displaying stats. Otherwise they seem to work.

You need to set IncludeInBlueprints = true.

Lafiel

https://cdn.discordapp.com/attachments/614304659229900814/656287857429839903/test_mod18-2.zip
This mod demonstrates above bug along with related multi-option all-buff activation bug and final calculation bug (probably random memory value for non-existing buffs).
You will have to comment and uncomment sections for various test case. The parts are corridor modified thrusters in Flight editor group.

Walt

Lafiel final calculation bug

I believe what's going on here is that you've created a feedback loop with the BuffPlasmaOp buff, so two adjacent parts keeping buffing each other, exponentially growing the buff value until it becomes infinity.

Lafiel related multi-option all-buff activation bug

I don't understand what this bug is. What am I supposed to be seeing?

Lafiel

Thanks a lot. I'll check them out.
Walt They are supposed to give different amounts of buff for horizontal and vertical mode via the multi-toggle. In the test, however, the total received buff is of both modes together 100% instead of 25% or 75%. It shows more because the basevalue of 100% is included.

Edit: So far I don't see anything different on my end. IncludeInBlueprints = true didn't seem to change anything. Buff Providers inside ToggledComponents still won't show any buff values in blueprint mode. I guess I will move back testing/checking for the next version to have a more reliable base.